fix spatial variation of water level in rainfall example #108
Conversation
Codecov ReportBase: 79.50% // Head: 79.50% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 79.50% 79.50%
=======================================
Files 6 6
Lines 610 610
Branches 99 99
=======================================
Hits 485 485
Misses 108 108
Partials 17 17 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -19,7 +19,13 @@ def cell_portrayal(cell: LakeCell) -> Tuple[float, float, float, float]: | |||
| if cell.water_level == 0: | |||
| return cell.elevation, cell.elevation, cell.elevation, 1 | |||
| else: | |||
| return 0, 0, 255, 1 | |||
| # return scaled blue color for water level | |||
| return ( | |||
There was a problem hiding this comment.
Is this supposed to be a color gradient? I couldn't spot any noticeable gradient. What if you exaggerate the gradient further?
There was a problem hiding this comment.
The screenshot was taken after 20 steps. Is it slightly better after 100 steps (or not)?
I guess initially there may not be enough raindrops to make a difference.
There was a problem hiding this comment.
I see. You probably need to add a comment explaining that an array returns a color gradient.
There was a problem hiding this comment.
Something like the recent update?
There was a problem hiding this comment.
Not enough info. People are not likely to be aware that an array instead of a scalar means gradient.
There was a problem hiding this comment.
Huh it does mean a single color after all. I thought we have color varying across space, and within a cell. In https://github.com/projectmesa/mesa/blob/fed83543487f6834b172f3a7c88754733e12c539/examples/shape_example/shape_example/server.py#L18, if you specify 2 color in an array, it becomes a gradient of color within 1 portrayal.
There was a problem hiding this comment.
Yes sorry about the confusion 😅
wang-boyu
force-pushed
the
fix/rainfall-example
branch
from
ac6af24
to
34b547e
Compare
wang-boyu
force-pushed
the
fix/rainfall-example
branch
from
34b547e
to
92613a9
Compare
Use scaled blue color to represent water level. The differences between cells are small so it may be hard to visualize the spatial variation.
Before the fix:
Now: