Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ga workflows to be consistent with mesa #185

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

wang-boyu
Copy link
Member

  • drop support for python 3.8
  • remove redundant linters which are included in pre-commit.ci
  • run release workflow when tags are created

@wang-boyu wang-boyu added the ci Release notes label label Jan 17, 2024
@wang-boyu wang-boyu added this to the v0.7.0 milestone Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73cfc90) 78.14% compared to head (a6639d8) 78.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files          10       10           
  Lines         691      691           
  Branches      151      151           
=======================================
  Hits          540      540           
  Misses        127      127           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EwoutH EwoutH requested a review from rht January 17, 2024 08:37
Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -1,6 +1,8 @@
name: Release
on:
push:
tags:
- "v*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the case as well in projectmesa/mesa?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't really matter, I think

@rht rht merged commit 6178160 into projectmesa:main Jan 17, 2024
11 checks passed
@wang-boyu wang-boyu deleted the ci/release-on-tags branch January 17, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants