Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add manual trigger to github actions #196

Closed
wants to merge 1 commit into from

Conversation

wang-boyu
Copy link
Member

There are three failing PRs (#187, #188, #189) but a fix to test cases was merged in another PR #194. I couldn't find a way to manually re-run failed jobs in the three failing PRs. This PR should add a mutual trigger to run jobs.

If I'm missing something and it's possible to re-run jobs, then this PR is not necessary.

@wang-boyu wang-boyu added the ci Release notes label label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.21%. Comparing base (f647e79) to head (8366619).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   78.21%   78.21%           
=======================================
  Files          10       10           
  Lines         693      693           
  Branches      151      151           
=======================================
  Hits          542      542           
  Misses        127      127           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rht
Copy link
Contributor

rht commented Mar 27, 2024

If you look at https://github.com/projectmesa/mesa/actions/runs/8207353176/job/22448466927?pr=2067, then the rerun failed jobs exists, even without the workflow_dispatch line in this PR in the projectmesa/mesa's build_lint.yml. How is it done in core Mesa?

@wang-boyu
Copy link
Member Author

Mesa should have the same settings since I copied over the config files from there. Strangely the re-run failed jobs button appears now, which wasn't there previously.

But I also figured out how to re-run tests without these buttons. I checked out the PR branch, did a rebase and force push.

I'll close this PR.

@wang-boyu wang-boyu closed this Mar 27, 2024
@wang-boyu wang-boyu deleted the ci/manual-trigger branch March 27, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants