Automatically assign unique_id's #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
quaquel
approved these changes
Sep 10, 2024
wang-boyu
approved these changes
Sep 10, 2024
wang-boyu
added
dependency
tpike3
approved these changes
Sep 10, 2024
|
@tpike3 thanks for reviewing! One little thing: I would like to merge my own PRs. In this case I think a squash merge was cleaner, to keep the commit log clean. So just an approve is good :) |
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the GeoAgent and tests to use the automatically assigned unique_ids from Mesa, instead of doing this manually.
The intro_tutorial still needs to be updated (that can be done in a separate PR).