Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rainfall and urban growth examples #80

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Conversation

wang-boyu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #80 (969db7f) into master (9376f21) will increase coverage by 1.79%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   76.25%   78.05%   +1.79%     
==========================================
  Files           7        7              
  Lines         556      556              
  Branches       93       93              
==========================================
+ Hits          424      434      +10     
+ Misses        117      107      -10     
  Partials       15       15              
Impacted Files Coverage Δ
mesa_geo/raster_layers.py 70.13% <0.00%> (+3.16%) ⬆️
mesa_geo/visualization/modules/MapVisualization.py 87.17% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9376f21...969db7f. Read the comment docs.

@rht
Copy link
Contributor

rht commented Jul 11, 2022

How big are the .asc files? Is it customary to gzip them?

examples/rainfall/README.md Outdated Show resolved Hide resolved
@wang-boyu
Copy link
Member Author

How big are the .asc files? Is it customary to gzip them?

These files are less than or around 1 MB each. Not sure how it is done usually but most of the time I work with them directly.

@rht
Copy link
Contributor

rht commented Jul 12, 2022

From looking at the .asc, it looks like it will be much smaller when compressed. I'd attempt to compress it.

@rht
Copy link
Contributor

rht commented Jul 12, 2022

I know it won't affect git clone's perf, because files are compressed in transit, but having a smaller repo size in people's laptop, for free (with gzip), would be nice.

@rht
Copy link
Contributor

rht commented Jul 12, 2022

That's a significant size reduction from ~1 MB each.

@wang-boyu
Copy link
Member Author

It's indeed much smaller. My only concern is that users won't be able to make a quick glance at those files without unzipping them first. But I've made the changes.

@rht
Copy link
Contributor

rht commented Jul 12, 2022

You also removed the JPG result, which I personally prefer (so as not to bloat the repo), but @Corvince might prefer it included. But anyway, LGTM.

@rht rht merged commit 879e329 into projectmesa:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants