Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Visualization: Update to Bootstrap 4.6.1 #1100

Closed
wants to merge 3 commits into from

Conversation

EwoutH
Copy link
Member

@EwoutH EwoutH commented Dec 7, 2021

Proof of Concept: Update from Bootstrap v3.3.7 to v4.6.1.

It also updates bootstrap-slider to 11.0.2 and bootstrap-switch its latest commit, Bttstrp/bootstrap-switch@2b316be.

To-do (any help is appreciated!)

My working branch is bootstrap-4. Feel free to work from there!

The branch can be installed with pip install git+https://github.com/EwoutH/mesa.git@bootstrap-4 for testing.

Screenshot_686Screenshot_687

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #1100 (c82dae3) into main (2228b3c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1100   +/-   ##
=======================================
  Coverage   88.93%   88.93%           
=======================================
  Files          19       19           
  Lines        1311     1311           
  Branches      265      265           
=======================================
  Hits         1166     1166           
  Misses        106      106           
  Partials       39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2228b3c...c82dae3. Read the comment docs.

@rht
Copy link
Contributor

rht commented Mar 29, 2022

@EwoutH #1195 might be relevant to minimize future diffs of this JS/CSS dependencies updates.

@rht
Copy link
Contributor

rht commented Apr 2, 2022

@EwoutH it should be easier to upgrade Bootstrap now. Also, if you are up for migrating the installation of the other JS dependencies to the method used in #1220.

@rht
Copy link
Contributor

rht commented Apr 16, 2022

All the JS deps have been removed from the repo. They are now downloaded on-the-fly during setup.py.

@rht
Copy link
Contributor

rht commented Apr 16, 2022

Superseded by #1282.

@rht rht closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants