Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx: Use PyData theme #1699

Merged
merged 1 commit into from
May 18, 2023
Merged

sphinx: Use PyData theme #1699

merged 1 commit into from
May 18, 2023

Conversation

rht
Copy link
Contributor

@rht rht commented May 16, 2023

This is an experiment in changing the doc theme.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (68b8e6c) 81.49% compared to head (8879217) 81.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1699   +/-   ##
=======================================
  Coverage   81.49%   81.49%           
=======================================
  Files          18       18           
  Lines        1405     1405           
  Branches      273      273           
=======================================
  Hits         1145     1145           
  Misses        214      214           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rht
Copy link
Contributor Author

rht commented May 16, 2023

@tpike3
Copy link
Member

tpike3 commented May 16, 2023

I like it! I am good with merging. @jackiekazil what do you think?

Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! and @jackiekazil also agreed.

@tpike3 tpike3 merged commit e3af2a5 into projectmesa:main May 18, 2023
@wang-boyu
Copy link
Member

Looks like https://mesa.readthedocs.io/en/main is updated but https://mesa.readthedocs.io/en/stable/ isn't.

@rht rht deleted the sphinx_theme branch May 18, 2023 21:32
@rht
Copy link
Contributor Author

rht commented May 18, 2023

I assume stable means the latest release, but not sure.

@rht
Copy link
Contributor Author

rht commented May 18, 2023

It's at commit 9a07a48, which commit message is "Bump version to 1.2.1", so it is the latest release.

@wang-boyu
Copy link
Member

Oh right, my bad. This is as expected then.

@tpike3 tpike3 added this to the Mesa 2.0 (Wellton) milestone Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants