Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix install for visualization tutorial in colab #1752

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix install for visualization tutorial in colab #1752

merged 1 commit into from
Aug 4, 2023

Conversation

tpike3
Copy link
Member

@tpike3 tpike3 commented Aug 4, 2023

I removed the -e argument in the pip install because for colab that stores the install in src directory and presents some other challenges of mesa-example not being imported easily.

Removing the -e installs mesa-examples in the standard colab install location and prevents an ImportError without effecting performance if someone is using a local instantiation of their jupyter notebook

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b53aa2f) 72.35% compared to head (1ac58a6) 72.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1752   +/-   ##
=======================================
  Coverage   72.35%   72.35%           
=======================================
  Files          20       20           
  Lines        1302     1302           
  Branches      246      246           
=======================================
  Hits          942      942           
  Misses        325      325           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpike3
Copy link
Member Author

tpike3 commented Aug 4, 2023

Sorry I also opened the legacy advanced tutorial so their is a bunch of noise of metadata changing but no actual changes; all significant changes for visualization tutorial are at the end

@rht
Copy link
Contributor

rht commented Aug 4, 2023

I would have not committed the legacy change, but it's fine.

@rht rht merged commit 856d4bc into projectmesa:main Aug 4, 2023
@tpike3 tpike3 added this to the Release 2.1.2 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants