Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor disabled space drawer option when rendering in the browser #1907

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

rlskoeser
Copy link
Contributor

@rlskoeser rlskoeser commented Dec 15, 2023

addresses #1906

I haven't quite wrapped my head around the new split between the render in browser / render in jupyter code, but this change seemed to resolve the problem

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ca5e8f9) 77.35% compared to head (b11e81e) 77.35%.

Files Patch % Lines
mesa/experimental/jupyter_viz.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1907   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files          15       15           
  Lines        1007     1007           
  Branches      220      220           
=======================================
  Hits          779      779           
  Misses        197      197           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @rlskoeser

@tpike3 tpike3 merged commit a97a483 into projectmesa:main Dec 16, 2023
12 of 13 checks passed
@tpike3
Copy link
Member

tpike3 commented Dec 16, 2023

@rlskoeser https://simrisk.pulcloud.io These are great! Could you point to the github repository for this, we want to try and replicate it for some of the seminal mesa examples

@rlskoeser
Copy link
Contributor Author

@tpike3 thanks, all the code is in this repository: https://github.com/Princeton-CDH/simulating-risk

@rlskoeser rlskoeser deleted the jupyterviz-nospace-browser branch December 18, 2023 14:13
@EwoutH EwoutH added the bug Release notes label label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants