Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reverse dict key and value for agents_by_type #1996

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Jan 24, 2024

This change is so that the agents_by_type API is compatible with Mesa 2.1.5 again.

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 +0.2% [-0.1%, +0.6%] 🔵 +0.1% [-0.0%, +0.3%]
Schelling large 🔵 +1.1% [+0.8%, +1.5%] 🔴 +6.6% [+4.6%, +8.3%]
WolfSheep small 🔵 +3.0% [+2.6%, +3.4%] 🔵 +0.6% [+0.5%, +0.8%]
WolfSheep large 🔴 +10.1% [+5.0%, +14.4%] 🔴 +9.6% [+6.0%, +13.2%]
BoidFlockers small 🔵 +1.7% [+1.4%, +2.1%] 🔵 +2.4% [+1.8%, +3.0%]
BoidFlockers large 🔵 +1.3% [+0.8%, +1.7%] 🔵 +1.7% [+1.4%, +2.0%]

@quaquel
Copy link
Member

quaquel commented Jan 24, 2024

Looks good to me, but you have 2 other changes here that are more ruff related. Do these belong within this PR?

@rht
Copy link
Contributor Author

rht commented Jan 24, 2024

The other commits, when done in separate PR, will be ignored in the release note anyway. This PR can be rebase and merged, if the goal is not to mix lint changes into 1 commit.

@quaquel
Copy link
Member

quaquel commented Jan 24, 2024

Fine with me either way.

@rht rht merged commit c0c8479 into projectmesa:main Jan 24, 2024
11 of 13 checks passed
@rht rht deleted the agents_by_type branch January 24, 2024 10:52
@EwoutH
Copy link
Member

EwoutH commented Jan 24, 2024

Thanks!

@EwoutH EwoutH added the bug Release notes label label Jan 26, 2024
EwoutH pushed a commit that referenced this pull request Jan 26, 2024
* fix: Reverse dict key and value for agents_by_type

* Apply ruff --fix .

* benchmark: Ignore Ruff import recommendation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants