DEVS/simulator: Use Model time #2248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quaquel
reviewed
Aug 26, 2024
| @@ -164,7 +157,7 @@ def schedule_event_relative( | |||
|
|
|||
| """ | |||
| event = SimulationEvent( | |||
| self.time + time_delta, | |||
| self.model._time + time_delta, | |||
There was a problem hiding this comment.
perhaps betraying my java background, but changing attributes of other objects directly like this makes me uncomfortable.
There was a problem hiding this comment.
I understand that. I think in this case it allows the model to be the ground truth of time. We should document it as "A DEVS simulator is an alternative way to manage agent activation and progress time".
|
Closing this, since it was just a conceptual PR to start thinking about this. @quaquel I would support a property that copies simulator time, if that makes implementation significantly more elegant. I'm also good with the simulator not keeping it's time at all (or keep it private in like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not intended to (ever) be merged, but to spark discussion about how the simulator could integrate with timekeeping in the model.
The main point that I want to discuss is that now that we are moving away from schedulers, and thus moving away from
schedulers.time, I don't to move time away from the model again (in this case tosimulator.time), where a datacollector or visualisation module is unable to find it.I think it would be logical if the simulator would update the model time. If one is used, the model time should also be increased on a step or otherwise, unless explicitly stated.
The reason this is a PR and not a discussion is that this way we can also see and discuss potential code issues.