-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move solara_viz back to experimental #2278
Conversation
Performance benchmarks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I like this.
Warning can be added once new-new viz is semi-stable.
Maybe we can also revert it back to JupyterViz. And then we can simply revert projectmesa/mesa-examples#155. Edit: There are a few more places where this needs to be changed, see: |
SolaraViz and JupyterViz both work. But the examples need to be updated anyway, so not sure. By the way I can take care of updating the examples. This way I get a better feeling on how the frontend is used and directly fix anything that's missing |
@rht do you agree with this approach? Would like to have your approval before merging |
I agree. |
This PR did break the CI, unfortunately:
The |
Move the current SolaraViz back into experimentals. This way users of Mesa 2.x that already adapted their frontend can continue to use it. But we will provide a different, stable API for Mesa 3 in #2263
Follow-up PRs should include a deprecation warning and link to a migration guide from the experimental SolaraViz to the new SolaraViz (to be written)