Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly test basic examples #2390

Merged
merged 7 commits into from
Oct 20, 2024
Merged

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Oct 19, 2024

This is a quick update to test_examples.py for testing the basic examples.

Presently, it only tests if the models run, no further assertions are made about e.g., results. So the main purpose of this type of test is integration testing.

@quaquel quaquel added testing Release notes label example Changes the examples or adds to them. labels Oct 19, 2024
@quaquel quaquel requested review from EwoutH and Corvince October 19, 2024 15:14
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 -3.6% [-5.0%, -2.1%] 🔵 +0.1% [-0.1%, +0.3%]
BoltzmannWealth large 🔵 +0.7% [+0.5%, +0.9%] 🔵 -0.1% [-0.6%, +0.6%]
Schelling small 🔵 +0.1% [-0.2%, +0.5%] 🔵 -1.0% [-1.3%, -0.8%]
Schelling large 🔵 +0.6% [-0.2%, +1.3%] 🔵 -0.4% [-1.5%, +1.0%]
WolfSheep small 🔵 +0.9% [+0.8%, +1.1%] 🔵 +1.1% [+1.0%, +1.3%]
WolfSheep large 🔵 +0.5% [-0.3%, +1.2%] 🔵 +0.8% [-1.1%, +2.5%]
BoidFlockers small 🔵 +0.6% [-0.0%, +1.3%] 🔵 -0.9% [-1.5%, -0.2%]
BoidFlockers large 🔵 -0.7% [-1.4%, +0.2%] 🔵 -0.7% [-1.2%, -0.3%]

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge code reduction, same functionality. Love it!

@quaquel quaquel merged commit 988ab71 into projectmesa:main Oct 20, 2024
11 of 12 checks passed
@quaquel quaquel deleted the update_test_examples branch November 4, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Changes the examples or adds to them. testing Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants