Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altair spaces #2397

Merged
merged 56 commits into from
Oct 24, 2024
Merged

Altair spaces #2397

merged 56 commits into from
Oct 24, 2024

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Oct 21, 2024

This adds altair support for new-style grids (moore, von neumann and hex), as well as old-style continuous spaces

@quaquel quaquel requested a review from Corvince October 21, 2024 17:25
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +2.3% [+0.6%, +4.0%] 🔵 -0.0% [-0.3%, +0.3%]
BoltzmannWealth large 🔵 +1.0% [+0.3%, +1.8%] 🔵 +1.4% [+0.2%, +2.8%]
Schelling small 🔵 +0.1% [-0.2%, +0.4%] 🔵 -0.1% [-0.4%, +0.2%]
Schelling large 🔵 -0.3% [-1.2%, +0.7%] 🔵 -0.5% [-2.4%, +1.2%]
WolfSheep small 🔵 -0.6% [-1.1%, -0.1%] 🔵 -0.4% [-1.4%, +0.6%]
WolfSheep large 🔵 +1.6% [-0.4%, +4.5%] 🔵 -0.6% [-3.5%, +2.1%]
BoidFlockers small 🔵 -0.9% [-1.4%, -0.5%] 🔵 -1.2% [-1.8%, -0.6%]
BoidFlockers large 🔵 -1.9% [-2.6%, -1.1%] 🔵 -1.9% [-2.4%, -1.5%]

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more robust than we currently do it, and no user API breaking changes

@quaquel quaquel merged commit 8b4e2c1 into projectmesa:main Oct 24, 2024
11 of 12 checks passed
@quaquel quaquel deleted the altair_spaces branch October 25, 2024 06:03
@EwoutH EwoutH added feature Release notes label experimental Release notes label labels Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Release notes label feature Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants