Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

space: Add note that Grids are maintenance only #2420

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

EwoutH
Copy link
Member

@EwoutH EwoutH commented Oct 25, 2024

Add a note to the space module level docstring that the Grids are maintenance only.

Also add the PropertyLayer to the classes and remove the Grid, since that's now private (and has been for a while).

Now looks like this:
image

Add a note to the space module level docstring that the Grids are maintenance only.

Also add the PropertyLayer to the classes and remove the Grid, since that's now private (and has been for a while).
@EwoutH EwoutH added the docs Release notes label label Oct 25, 2024
@EwoutH EwoutH added this to the v3.0 milestone Oct 25, 2024
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 -2.3% [-3.6%, -0.9%] 🔵 +1.0% [+0.7%, +1.3%]
BoltzmannWealth large 🔵 +0.0% [-0.6%, +0.8%] 🔵 +4.2% [+2.6%, +5.6%]
Schelling small 🔵 -0.3% [-0.8%, +0.1%] 🔵 +0.3% [+0.0%, +0.5%]
Schelling large 🔵 -0.9% [-2.2%, +0.2%] 🔵 -1.0% [-3.2%, +1.1%]
WolfSheep small 🔵 +0.1% [-0.2%, +0.3%] 🔵 +0.3% [+0.2%, +0.5%]
WolfSheep large 🔵 +0.7% [+0.3%, +1.1%] 🔵 +1.9% [+1.0%, +2.7%]
BoidFlockers small 🔵 +1.0% [+0.4%, +1.7%] 🔵 +0.2% [-0.4%, +0.9%]
BoidFlockers large 🔵 +0.7% [+0.4%, +1.1%] 🔵 +0.4% [-0.4%, +1.2%]

@EwoutH EwoutH requested a review from quaquel October 25, 2024 10:37
@EwoutH EwoutH marked this pull request as ready for review October 25, 2024 10:37
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 -1.0% [-2.5%, +0.5%] 🔵 -0.9% [-1.1%, -0.7%]
BoltzmannWealth large 🔵 -1.1% [-1.5%, -0.7%] 🔵 -0.3% [-1.3%, +0.7%]
Schelling small 🔵 +0.4% [+0.1%, +0.7%] 🔵 -0.2% [-0.4%, -0.0%]
Schelling large 🔵 +1.4% [+0.3%, +2.4%] 🔵 +0.0% [-1.4%, +1.4%]
WolfSheep small 🔵 +1.1% [+0.8%, +1.5%] 🔵 -0.7% [-0.9%, -0.5%]
WolfSheep large 🔵 +1.3% [+0.9%, +1.6%] 🔵 +0.7% [-0.2%, +1.6%]
BoidFlockers small 🔵 +0.2% [-0.3%, +0.7%] 🔵 -0.9% [-1.7%, -0.2%]
BoidFlockers large 🔵 -0.0% [-0.6%, +0.6%] 🔵 +0.0% [-0.6%, +0.8%]

Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quaquel
Copy link
Member

quaquel commented Oct 25, 2024

indeed go ahead and merge it.

One thing I noted but can be done in a separate: remove HexGrid from mesa.space. It has been deprecated already so it can be safely removed.

@EwoutH EwoutH merged commit 4215706 into main Oct 25, 2024
12 of 13 checks passed
@EwoutH EwoutH deleted the grid_maintenance_note branch October 26, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants