Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes for draw_property_layers #2548

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Dec 13, 2024

While trying to update sugarscape to use draw_property_layer, I encountered a few bugs.

  1. The integration into cell spaces includes its own version of PropertyLayer, so the isinstance check needs to account for this.
  2. There was a transpose in the imshow that should have been removed as part of the larger matplotlib visualization overhaul because there draw_property_layer shifted to using origin="lower"
  3. In the sugarscape update (Switch sugarscape to using property layers #2546) I forgot to remove some path stuff from app.py.

This comment was marked as off-topic.

@quaquel quaquel requested a review from EwoutH December 14, 2024 08:24
@quaquel quaquel merged commit f72a268 into projectmesa:main Dec 14, 2024
11 checks passed
@quaquel quaquel deleted the sugarscape_ui branch December 14, 2024 09:28
@EwoutH EwoutH added example Changes the examples or adds to them. bug Release notes label visualisation and removed example Changes the examples or adds to them. labels Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label visualisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants