Draw space(#2638) #2657
Closed
Draw space(#2638) #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance benchmarks:
|
|
@aarav-shukla07 I think you should take a look at implementation and Jan's comment on #2640. Also take a look at the discussion #2642. |
quaquel
reviewed
Feb 2, 2025
| @@ -1,4 +1,4 @@ | |||
| name: example-environment | |||
| name: mesa-tutorials | |||
There was a problem hiding this comment.
please keep PRs focussed, this is a separate issue and thus does not belong in this PR. I suggest reverting all changes to this file
quaquel
reviewed
Feb 2, 2025
| @@ -108,7 +108,9 @@ def draw_space( | |||
| space, | |||
| agent_portrayal: Callable, | |||
| propertylayer_portrayal: dict | None = None, | |||
| ax: Axes | None = None, | |||
| ax_grid: Axes | None = None, | |||
There was a problem hiding this comment.
I am not convinced that this is the ideal solution for an improved API. You now have to pass the axes multiple times in the most common use case. I suggest we hatch out the API design in #2640 first before opening a PR.
quaquel
reviewed
Feb 2, 2025
| if hasattr(space, "agents") and space.agents: | ||
| if ax_agents is None: | ||
| ax_agents = ax_grid | ||
| draw_agents(space, agent_portrayal, ax=ax_agents) |
There was a problem hiding this comment.
This is a good name for a new method. But I don't see an implementation of draw_agents at the moment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The draw_space method in Mesa's visualization module fails when there are no agents on the grid. This bug prevents the visualization from rendering correctly in models with empty grids, limiting the usability of the visualization tools for certain scenarios.
Bug / Issue
Issue: #2638
Description: The draw_space method assumes there is at least one agent to determine the grid's properties. When the grid is empty, this assumption causes the method to fail or behave incorrectly.
Expected Behavior: The draw_space method should render the grid correctly, even when there are no agents.
Actual Behavior: The method fails or produces incorrect visualizations when the grid is empty.
Implementation
Modified the draw_space function
Testing
All the tests get passed from the test_space.py of tests folder .
Additional Notes
Potential Side Effects: None expected. The changes only affect the visualization of empty grids and do not modify the core functionality of the grid or agents.
Dependencies: None.
Related Work: This fix is part of ongoing efforts to improve Mesa's visualization tools and ensure they work reliably in all scenarios.