-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis: Add pypy3 #883
Travis: Add pypy3 #883
Conversation
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
==========================================
- Coverage 88.86% 86.14% -2.72%
==========================================
Files 19 20 +1
Lines 1132 1083 -49
Branches 189 171 -18
==========================================
- Hits 1006 933 -73
- Misses 92 121 +29
+ Partials 34 29 -5
Continue to review full report at Codecov.
|
I'm not sure why there is no Travis running here ... |
No idea why it doesn't show up. It did run though, but failed at installing pandas (https://travis-ci.org/github/projectmesa/mesa/jobs/718907972) |
It looks like it fails at pandas' dependency, ujson. I will keep this PR open and retry on future version of PyPy. Though PyPy developers claimed that pandas has been supported since pypy5.9 (https://doc.pypy.org/en/latest/release-v5.9.0.html#pypy2-7-and-pypy3-5-v5-9-dual-release). The current Travis PyPy is 7.1.1. |
Your link only mentions pypy2.7, but from what I could infer from googling around, yes, it should work with pandas. Maybe just an issue with travis? @rht could you (or someone else) try it locally? |
Tested on my laptop.
With normal python 3.8
|
I probably need a simulation with a huge grid size in order to highlight PyPy's speedup. |
I ran the comparison on the
CPython 3.8
A 1.9x speedup! |
Here I removed 3.5 to make room for PyPy3. This is also justified by the fact that 3.5's EOL 2020-09-13. |
This addresses #882.