Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Unify bazel cache #129

Merged
merged 1 commit into from
Mar 30, 2022
Merged

CI: Unify bazel cache #129

merged 1 commit into from
Mar 30, 2022

Conversation

snazy
Copy link
Member

@snazy snazy commented Mar 30, 2022

The bazel build (for the conformance tests) does not depend on the Java version, so there should be only one cache-key for the bazel-cache.

The bazel build (for the conformance tests) does not depend on the Java version, so there should be only one cache-key for the bazel-cache.
@snazy snazy requested a review from XN137 March 30, 2022 14:00
Copy link
Contributor

@XN137 XN137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never ran bazel so not sure what files are in there so trusting you it doesnt depend on java version in this case 😅

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #129 (f0d31a3) into main (e7562cc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #129   +/-   ##
=========================================
  Coverage     80.31%   80.31%           
  Complexity     1829     1829           
=========================================
  Files           100      100           
  Lines          7875     7875           
  Branches       1143     1143           
=========================================
  Hits           6325     6325           
  Misses         1033     1033           
  Partials        517      517           
Flag Coverage Δ
java 80.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ba087...f0d31a3. Read the comment docs.

@snazy snazy merged commit b7f5f60 into projectnessie:main Mar 30, 2022
@snazy snazy deleted the unify-bazel-cache branch September 27, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants