Do not publish build dependencies #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
do-not-pub-build-dep-mgmt
branch
from
e72e0f1 to
84c60ab
Compare
Before projectnessie#173 the published `cel-parent` pom contained no Maven `<dependencyManagement>`. With projectnessie#173, it appeared, which lets CEL-Java's *build* dependencies leak into other projects. Especially the dependency to antlr can cause issues downstream. Similar for the published Gradle `module.json`s - here the `cel-parent` must become a `compileOnly` dependency, so it does not "leak" downstream.
snazy
force-pushed
the
do-not-pub-build-dep-mgmt
branch
from
84c60ab to
0de7c26
Compare
Codecov Report
@@ Coverage Diff @@
## main #188 +/- ##
=========================================
Coverage 80.37% 80.37%
Complexity 1835 1835
=========================================
Files 100 100
Lines 7899 7899
Branches 1143 1143
=========================================
Hits 6349 6349
Misses 1033 1033
Partials 517 517
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
nastra
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #173 the published
cel-parentpom contained no Maven<dependencyManagement>. With #173, it appeared, which letsCEL-Java's build dependencies leak into other projects.
Especially the dependency to antlr can cause issues downstream.
Similar for the published Gradle
module.jsons - here thecel-parentmust become acompileOnlydependency, so itdoes not "leak" downstream.