Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run conformance tests only once #202

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

snazy
Copy link
Member

@snazy snazy commented Jun 10, 2022

It's just not necessary to run the conformance tests against multiple
different Java versions, because those tests do not hit any code path
in CEL-Java that any way dependends on the Java version.

Running the conformance tests only for one Matrix job also improves
CI runtime, because Bazel's cache depends on the Java version.

It's just not necessary to run the conformance tests against multiple
different Java versions, because those tests do not hit any code path
in CEL-Java that any way dependends on the Java version.

Running the conformance tests only for one Matrix job also improves
CI runtime, because Bazel's cache depends on the Java version.
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #202 (e52822b) into main (c44565d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #202   +/-   ##
=========================================
  Coverage     80.37%   80.37%           
  Complexity     1835     1835           
=========================================
  Files           100      100           
  Lines          7899     7899           
  Branches       1143     1143           
=========================================
  Hits           6349     6349           
  Misses         1033     1033           
  Partials        517      517           
Flag Coverage Δ
java 80.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c44565d...e52822b. Read the comment docs.

Copy link
Contributor

@XN137 XN137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaml changes lgtm but i cant judge whether conformance tests could show different behavior depending on the java version or not, so have to trust you on this one ;)

@snazy snazy merged commit 4245150 into projectnessie:main Jun 10, 2022
@snazy snazy deleted the conformance-only-once branch June 10, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants