Add ULong list support for fixed32-like repeated fields #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
reviewed
Jul 3, 2023
|
@snazy Thank you! |
buildbreaker
commented
Jul 3, 2023
| } | ||
|
|
||
| @Test | ||
| public void uintInList() throws ScriptException { |
buildbreaker
commented
Jul 3, 2023
| } | ||
|
|
||
| @Test | ||
| public void uintNotInList() throws ScriptException { |
|
@snazy Sorry, the tests are failing. I'll fix them before I ping you for another review. |
buildbreaker
commented
Jul 5, 2023
| return Integer.class; | ||
| case INT64: | ||
| case SFIXED64: | ||
| case SINT64: | ||
| return Long.class; | ||
| case UINT32: | ||
| case UINT64: | ||
| case FIXED32: |
There was a problem hiding this comment.
This change is to make reading fixed32 consistent. The other parts of the file considers fixed32s as a ULong/Uint (e.g. here)
|
Hey @snazy this is ready for you to take another look when you're available :) Happy to chat if you have any questions! |
snazy
reviewed
Jul 15, 2023
core/src/main/java/org/projectnessie/cel/interpreter/AttributeFactory.java
Outdated
Show resolved
Hide resolved
|
@snazy Thanks for the review. I removed the redundant check that you called out! |
snazy
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I observed was that a fixed32 gets interpreted as an
intrather than alongduring evaluation.There are various parts of
FileDescriptionthat swapped between considering fixed32s as an integer or a long. The change here is to also make things more consistent within each other.