Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update material-ui npm dependecies from version 4 to 5 #5326

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

VladimirYushkevich
Copy link
Contributor

Dependent bot failed to bump npm dependencies because @react: 18 doesn't support @material-ui: 4: mui/material-ui#34081. One of the option is to upgrade @material-ui: 4 to @mui: 5 which can be beneficial for further upgrades: https://mui.com/material-ui/migration/migration-v4/#why-you-should-migrate.
In this PR:

dimas-b
dimas-b previously approved these changes Oct 5, 2022
Copy link
Member

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a local build - the UI seems to be operational :)

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 81.98% // Head: 83.60% // Increases project coverage by +1.61% 🎉

Coverage data is based on head (00515d8) compared to base (1fa4654).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5326      +/-   ##
==========================================
+ Coverage   81.98%   83.60%   +1.61%     
==========================================
  Files          18       48      +30     
  Lines         322     1793    +1471     
  Branches       89      346     +257     
==========================================
+ Hits          264     1499    +1235     
- Misses         47      217     +170     
- Partials       11       77      +66     
Flag Coverage Δ
java ∅ <ø> (?)
javascript 81.98% <100.00%> (ø)
python 83.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ui/src/CommitLog/CommitLog.tsx 64.00% <ø> (ø)
ui/src/TableHead/TableHead.tsx 86.20% <ø> (ø)
ui/src/TableListing/TableListing.tsx 93.10% <100.00%> (ø)
python/pynessie/commands/_branch_tag_handlers.py 60.34% <0.00%> (ø)
python/pynessie/cli.py 84.44% <0.00%> (ø)
python/pynessie/commands/branch.py 91.30% <0.00%> (ø)
python/pynessie/commands/config.py 100.00% <0.00%> (ø)
python/pynessie/commands/reflog.py 63.04% <0.00%> (ø)
python/pynessie/commands/content/__init__.py 100.00% <0.00%> (ø)
python/pynessie/commands/diff.py 88.23% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@snazy snazy merged commit eba33b5 into projectnessie:main Oct 5, 2022
@VladimirYushkevich VladimirYushkevich deleted the update-material-ui branch October 7, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants