Revert "(bug) when cluster is marked as deleted avoid triggering clea… #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nup" Sveltos deploys resources in the management cluster when the `deploymenType` is set to `Local`. Even if a cluster is marked as deleted, Sveltos will still need to remove all resources deployed in the management cluster for that cluster. So this PR lets Sveltos undeploy even for clusters marked as deleted. If the managed cluster API server is unreachable after the Helm SDK uninstall is triggered, the Helm SDK will get stuck. Helm charts are only deployed in the matching cluster, so Sveltos will skip calling Helm uninstall for any deleted cluster. This reverts commit ce9e7f6.
gianlucam76
force-pushed
the
fix-cleanup
branch
from
8218ffd to
2337f97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sveltos deploys resources in the management cluster when the
deploymenTypeis set toLocal.Even if a cluster is marked as deleted, Sveltos will still need to remove all resources deployed in the management cluster for that cluster. So this PR lets Sveltos undeploy even for clusters marked as deleted.
If the managed cluster API server is unreachable after the Helm SDK uninstall is triggered, the Helm SDK will get stuck. Helm charts are only deployed in the matching cluster, so Sveltos will skip calling Helm uninstall for any deleted cluster.
This reverts commit ce9e7f6.
Fixes #719