(feat) better handle conflicts with Helm charts #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Sveltos detects a conflict during ClusterSummary reconciliation, Sveltos requeues the ClusterSummary instance after a fixed retry interval (default: 60 seconds). For Helm charts, Sveltos leverages its knowledge of competing ClusterSummaries. Only one ClusterSummary is granted management rights for a specific Helm chart in a given managed cluster. Others are denied and flagged as failures. If the managing ClusterSummary is deleted, Sveltos requeues all contenders. With this PR, for Helm charts, a conflict is treated as non-retriable. Sveltos will retry reconciliation once the conflict is resolved.
gianlucam76
force-pushed
the
helm-chart-conflict
branch
from
51a7e6f to
e7c58f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Sveltos detects a conflict during ClusterSummary reconciliation, Sveltos requeues the ClusterSummary instance after a fixed retry interval (default: 60 seconds).
For Helm charts, Sveltos leverages its knowledge of competing ClusterSummaries. Only one ClusterSummary is granted management rights for a specific Helm chart in a given managed cluster. Others are denied and flagged as failures.
If the managing ClusterSummary is deleted, Sveltos requeues all contenders. With this PR, for Helm charts, a conflict is treated as non-retriable. Sveltos will retry reconciliation once the conflict is resolved.