bug: use helm chart namespace when collecting resources #126
+67
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a ClusterProfile is using configuration drift detection: 1. addon-controller gets list of deployed resources 2. passes this information in a ResourceSummary to drift-detection-manager 3. drift-detection-manager starts watching those resources and when it detects a configuration drift, drift-detection-manager reports it to management cluster causing a new reconciliation With respect to Helm charts, addon-controller gets list of deployed resources using helm SDK and using manifest. In certain scenarios, like this [one](projectsveltos/addon-controller#363) manifest does not contain namespace for namespace resources like deployments. If namespace is not set for namespace resource, point projectsveltos#3 won't work. This PR fixes that. When drift-detection-manager gets resources deployed by addon-controller because of an Helm chart, it adds the helm chart namespace. This information is later on processed with dynamic.ResourceInterface which ignores namespace for cluster wide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a ClusterProfile is using configuration drift detection:
With respect to Helm charts, addon-controller gets list of deployed resources using helm SDK and using manifest.
In certain scenarios, like this one manifest does not contain namespace for namespace resources like deployments.
If namespace is not set for namespace resource, point #3 won't work.
This PR fixes that. When drift-detection-manager gets resources deployed by addon-controller because of an Helm chart, it adds the helm chart namespace. This information is later on processed with dynamic.ResourceInterface which ignores namespace for cluster wide.