(feat) Make token indefinite #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When registering the management cluster, register-mgmt-cluster can be passed this arg: `service-account-token=true` When that is set, register-mgmt-cluster creates a Secret of type `kubernetes.io/service-account-token` Instead of generating a token with an expiration, the token is taken from the newly created Secret.
gianlucam76
force-pushed
the
service-account-token
branch
from
04c2de5 to
0dc1b1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering the management cluster, register-mgmt-cluster can be passed this arg:
service-account-token=trueWhen that is set, register-mgmt-cluster creates a Secret of type
kubernetes.io/service-account-tokenInstead of generating a token with an expiration, the token is taken from the newly created Secret.
Fixes #92