(bug) reset token renewal to one hour #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version v0.45.0 token renewal was set to one hour. In release v0.46.0 this was increased to three hours. Since the new value was larger than older one, after upgrade Sveltos did not renew the token for three hours. But the previously generated token (created during v0.45.0) was set to one hour. So by the time, after upgrade, Sveltos tried to renew the token it was already expired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version v0.45.0 token renewal was set to one hour. In release v0.46.0 this was increased to three hours.
Since the new value was larger than older one, after upgrade Sveltos did not renew the token for three hours. But the previously generated token (created during v0.45.0) was set to one hour. So by the time, after upgrade, Sveltos tried to renew the token it was already expired.