show addons: fix cluster filter #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When displaying deployed add-ons, command allows filtering by namespace and cluster name. Because of an issue, filtering by cluster name was returning no result. This PR fixes it. ``` sveltosctl show addons +-----------------------------+---------------+-----------+----------------+---------+-------------------------------+------------------------+ | CLUSTER | RESOURCE TYPE | NAMESPACE | NAME | VERSION | TIME | PROFILES | +-----------------------------+---------------+-----------+----------------+---------+-------------------------------+------------------------+ | default/clusterapi-workload | helm chart | kyverno | kyverno-latest | 3.0.1 | 2024-02-14 16:12:47 +0100 CET | ClusterProfile/kyverno | | default/clusterapi-workload | helm chart | nginx | nginx-latest | 0.14.0 | 2024-02-14 16:14:50 +0100 CET | ClusterProfile/kyverno | +-----------------------------+---------------+-----------+----------------+---------+-------------------------------+------------------------+ ``` Filter by namespace ``` sveltosctl show addons --namespace=default +-----------------------------+---------------+-----------+----------------+---------+-------------------------------+------------------------+ | CLUSTER | RESOURCE TYPE | NAMESPACE | NAME | VERSION | TIME | PROFILES | +-----------------------------+---------------+-----------+----------------+---------+-------------------------------+------------------------+ | default/clusterapi-workload | helm chart | kyverno | kyverno-latest | 3.0.1 | 2024-02-14 16:12:47 +0100 CET | ClusterProfile/kyverno | | default/clusterapi-workload | helm chart | nginx | nginx-latest | 0.14.0 | 2024-02-14 16:14:50 +0100 CET | ClusterProfile/kyverno | +-----------------------------+---------------+-----------+----------------+---------+-------------------------------+------------------------+ ``` Filter by namespace and cluster name ``` sveltosctl show addons --namespace=default --cluster=clusterapi-workload +-----------------------------+---------------+-----------+----------------+---------+-------------------------------+------------------------+ | CLUSTER | RESOURCE TYPE | NAMESPACE | NAME | VERSION | TIME | PROFILES | +-----------------------------+---------------+-----------+----------------+---------+-------------------------------+------------------------+ | default/clusterapi-workload | helm chart | kyverno | kyverno-latest | 3.0.1 | 2024-02-14 16:12:47 +0100 CET | ClusterProfile/kyverno | | default/clusterapi-workload | helm chart | nginx | nginx-latest | 0.14.0 | 2024-02-14 16:14:50 +0100 CET | ClusterProfile/kyverno | +-----------------------------+---------------+-----------+----------------+---------+-------------------------------+------------------------+ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying deployed add-ons, command allows filtering by namespace and cluster name.
Because of an issue, filtering by cluster name was returning no result.
This PR fixes it.
Filter by namespace
Filter by namespace and cluster name
Fixes #210