-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated catalog update commit message is formatted incorrectly #136
Comments
My first instinct was that the commit message is not formatted correctly; however investigations showed that the commit messages are formatted correctly. A test also showed that the issue cannot be reproduced on GitHub, so I assume this is a GitLab issue after all. I'll try to reproduce the issue |
Related: https://gitlab.com/gitlab-org/gitlab-foss/-/issues/62905 |
The commit message does indeed contain a leading newline: commodore/commodore/catalog.py Lines 41 to 51 in 9a498fa
I assume the git cli and GitHub just trim that away; either during display or during commit. I try to reproduce the issue and report it to GitLab. |
@simu since this will be forever until it is fixed in GitLab, should we in the mean time fix this in commodore? |
Nice catch, I tried to find the cause for this issue multiple times as well but wasn't successful! 🎉 |
I vote for "fixing" this in commodore, PR welcome 😉 |
I think this is within my Python knowledge |
Remove leading newline from commit messages
When looking at the commit history for a cluster catalog in GitLab, the commit title is empty (which leads to some usability issues with GitLab).
Steps to Reproduce the Problem
Actual Behavior
Commit title is empty
Expected Behavior
Commit has a proper title
The text was updated successfully, but these errors were encountered: