Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated catalog update commit message is formatted incorrectly #136

Closed
mhutter opened this issue Jul 7, 2020 · 7 comments · Fixed by #139
Closed

Automated catalog update commit message is formatted incorrectly #136

mhutter opened this issue Jul 7, 2020 · 7 comments · Fixed by #139

Comments

@mhutter
Copy link
Contributor

mhutter commented Jul 7, 2020

When looking at the commit history for a cluster catalog in GitLab, the commit title is empty (which leads to some usability issues with GitLab).

image

Steps to Reproduce the Problem

  1. check existing catalogs

Actual Behavior

Commit title is empty

Expected Behavior

Commit has a proper title

@mhutter
Copy link
Contributor Author

mhutter commented Jul 8, 2020

My first instinct was that the commit message is not formatted correctly; however investigations showed that the commit messages are formatted correctly.

A test also showed that the issue cannot be reproduced on GitHub, so I assume this is a GitLab issue after all.

I'll try to reproduce the issue

@mhutter
Copy link
Contributor Author

mhutter commented Jul 8, 2020

@mhutter
Copy link
Contributor Author

mhutter commented Jul 8, 2020

The commit message does indeed contain a leading newline:

return f"""
Automated catalog update from Commodore
Component commits:
{component_commits}
Configuration commits:
{config_commits}
Compilation timestamp: {now}
"""

I assume the git cli and GitHub just trim that away; either during display or during commit. I try to reproduce the issue and report it to GitLab.

@mhutter
Copy link
Contributor Author

mhutter commented Jul 8, 2020

@simu since this will be forever until it is fixed in GitLab, should we in the mean time fix this in commodore?

@srueg
Copy link
Contributor

srueg commented Jul 8, 2020

Nice catch, I tried to find the cause for this issue multiple times as well but wasn't successful! 🎉

@srueg
Copy link
Contributor

srueg commented Jul 8, 2020

I vote for "fixing" this in commodore, PR welcome 😉

@mhutter
Copy link
Contributor Author

mhutter commented Jul 8, 2020

I think this is within my Python knowledge

@srueg srueg closed this as completed in #139 Jul 9, 2020
srueg pushed a commit that referenced this issue Jul 9, 2020
Remove leading newline from commit messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants