Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getValueOrDefault helper #125

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Add getValueOrDefault helper #125

merged 2 commits into from
Jun 30, 2020

Conversation

corvus-ch
Copy link
Contributor

No description provided.

@corvus-ch corvus-ch self-assigned this Jun 30, 2020
@corvus-ch corvus-ch requested review from simu and srueg June 30, 2020 11:59
@corvus-ch corvus-ch marked this pull request as ready for review June 30, 2020 12:00
@srueg
Copy link
Contributor

srueg commented Jun 30, 2020

Small typo in the commit message & PR title: getCalueOrDefault

@corvus-ch corvus-ch changed the title Add getCalueOrDefault helper Add getValueOrDefault helper Jun 30, 2020
simu
simu approved these changes Jun 30, 2020
View reviewed changes
commodore/lib/commodore.libjsonnet Outdated Show resolved Hide resolved
@corvus-ch @simu
Apply suggestions from code review
2149091 
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
@corvus-ch corvus-ch merged commit 5840f34 into master Jun 30, 2020
@corvus-ch corvus-ch deleted the value_default branch June 30, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srueg srueg srueg approved these changes

@simu simu simu approved these changes

Assignees

@corvus-ch corvus-ch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corvus-ch @srueg @simu