Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper makeMergeable #126

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Add helper makeMergeable #126

merged 2 commits into from
Jun 30, 2020

Conversation

corvus-ch
Copy link
Contributor

No description provided.

@corvus-ch corvus-ch self-assigned this Jun 30, 2020
@corvus-ch corvus-ch marked this pull request as ready for review June 30, 2020 13:41
simu
simu approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

commodore/lib/commodore.libjsonnet Outdated Show resolved Hide resolved
commodore/lib/commodore.libjsonnet Outdated Show resolved Hide resolved
commodore/lib/commodore.libjsonnet Outdated Show resolved Hide resolved
@corvus-ch @simu
Apply suggestions from code review
8317807 
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
@corvus-ch corvus-ch merged commit f440b7f into master Jun 30, 2020
@corvus-ch corvus-ch deleted the meargeable branch June 30, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees

@corvus-ch corvus-ch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corvus-ch @simu