Allow overriding Git user info for catalog commits #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR @daiboruta |
srueg
suggested changes
Jul 10, 2020
simu
changed the title
This commit introduces new arguments for `commodore catalog compile` for overriding local Git user information when pushing commits to a cluster catalog. By default Commodore will use the local Git user information for catalog commits. To improve compatibility with existing Git configurations, the arguments are named `--git-author-name` and `--git-author-email` to pick up the familiar `GIT_AUTHOR_NAME` and `GIT_AUTHOR_EMAIL` environment variables without any further configuration. Please note: Commodore does not allow you to override commit author and committer separately, and will use the provided author name and email, if any, as both commit author and committer. The commit also updates docker-compose.yaml to map `~/.gitconfig` into the container to propagate the global Git config into the container. This simplifies reusing the Git author configuration on the host system when running Commodore locally using docker-compose. Resolves projectsyn#63
srueg
reviewed
Jul 21, 2020
srueg
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces new arguments for
commodore catalog compileforoverriding local Git user information when pushing commits to a cluster
catalog.
By default Commodore will use the local Git user information for catalog
commits.
To improve compatibility with existing Git configurations, the arguments
are named
--git-author-nameand--git-author-emailto pick up thefamiliar
GIT_AUTHOR_NAMEandGIT_AUTHOR_EMAILenvironment variableswithout any further configuration.
Please note: Commodore does not allow you to override commit author and
committer separately, and will use the provided author name and email,
if any, as both commit author and committer.
The commit also updates docker-compose.yaml to map
~/.gitconfigintothe container to propagate the global Git config into the container.
This simplifies reusing the Git author configuration on the host system
when running Commodore locally using docker-compose.
Checklist