Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply component template to commodore itself #145

Merged
merged 6 commits into from
Jul 23, 2020
Merged

Apply component template to commodore itself #145

merged 6 commits into from
Jul 23, 2020

Conversation

corvus-ch
Copy link
Contributor

@corvus-ch corvus-ch commented Jul 22, 2020 •
edited
Loading

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the ./CHANGELOG.md.

@corvus-ch corvus-ch self-assigned this Jul 22, 2020
@corvus-ch corvus-ch marked this pull request as ready for review July 22, 2020 15:08
@corvus-ch corvus-ch requested review from tobru and srueg July 22, 2020 15:08
@corvus-ch
Copy link
Contributor Author

corvus-ch commented Jul 22, 2020 •
edited
Loading

@srueg @simu @Kidswiss @tobru Is this the moment to drop the DCO?

@tobru
Copy link
Contributor

tobru commented Jul 23, 2020

Yes, I'd drop DCO.

srueg
srueg suggested changes Jul 23, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
corvus-ch added 5 commits July 23, 2020 11:29
@corvus-ch
Add issue default labels
9775d46
@corvus-ch
Update contribution guide line
e866874 
Link to general contribution guide of project Syn.
@corvus-ch
Extend readme
3f2a98f 
Added some pieces that are part of the project template but were not
applied here.
@corvus-ch
Add code of conduct
39645d2
@corvus-ch
Update changelog
393ca72
@corvus-ch
Apply suggestions from code review
ce7f1fc 
Co-authored-by: Simon Rüegg <simon.ruegg@vshn.ch>
@corvus-ch corvus-ch requested a review from srueg July 23, 2020 09:31
@corvus-ch
Copy link
Contributor Author

DCO dropped.

@srueg srueg merged commit aafe89b into master Jul 23, 2020
@srueg srueg deleted the meta branch July 23, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobru tobru tobru approved these changes

@srueg srueg srueg approved these changes

Assignees

@corvus-ch corvus-ch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corvus-ch @tobru @srueg