Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Discovery With Reclass #160

Merged
merged 5 commits into from
Sep 3, 2020
Merged

Component Discovery With Reclass #160

merged 5 commits into from
Sep 3, 2020

Conversation

srueg
Copy link
Contributor

@srueg srueg commented Aug 12, 2020

One consequence of this is, that the hierarchy can't reference parameters which are defined in component classes (i.e. defaults). This is due to the fact that a reclass inventory must be able to resolve all references in order to be rendered. There's no mechanism to ignore invalid references (like there is for ignoring inexistent class files).

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the ./CHANGELOG.md.
  • Link this PR to related issues.

Closes #138

@srueg srueg changed the title Fake deps Component Discovery With Reclass Aug 12, 2020
@srueg srueg requested a review from simu August 12, 2020 13:37
@srueg srueg requested review from Kidswiss and corvus-ch August 31, 2020 09:00
@srueg srueg marked this pull request as ready for review August 31, 2020 12:50
@Kidswiss
Copy link
Contributor

As from today's sync:

Tested to access a puppet profile variable in hiera, it doesn't seem to be working.

@tobru
Copy link
Contributor

tobru commented Aug 31, 2020

Please also make sure that this is documented, maybe needs to be done after #147 has been merged.

@srueg
Copy link
Contributor Author

srueg commented Aug 31, 2020

As discussed during the SYNc today: Since this is also not allowed in Puppet and it's probably better that way anyway, we'll proceed with this approach and from now on don't allow parameters which are set in components to be referenced from the inventory.

@simu
Copy link
Member

simu commented Sep 2, 2020

Currently testing this for some "common" usecases. What I found so far is that with this approach we'll have to rethink how local mode works, as you now can't just add a component in the inventory somewhere and run catalog compile --local to inspect the changes.

@srueg
Copy link
Contributor Author

srueg commented Sep 2, 2020

I don't think I understand the problem. This wasn't possible before either?

@simu
Copy link
Member

simu commented Sep 2, 2020

It is currently possible for any component that the file-based discovery mechanism finds and downloads.

Simon Rüegg and others added 5 commits September 2, 2020 18:07
To be able to use the exposed option of ignoring missing classes in
Kapitan.
So the inventory is ready and all files and directories are where they
should be.
By enabling `ignore_class_notfound` missing component classes are
ignored.
@srueg srueg merged commit 0d81015 into master Sep 3, 2020
@srueg srueg deleted the fake-deps branch September 3, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fake Components During Discovery
5 participants