Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trailing newline when writing a jsonnetfile.json #393

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Add trailing newline when writing a jsonnetfile.json #393

merged 2 commits into from
Dec 8, 2021

Conversation

simu
Copy link
Member

@simu simu commented Dec 7, 2021 •
edited
Loading

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@simu simu added the bug Something isn't working label Dec 7, 2021
@simu simu changed the title Add trailing newline whenever we write a jsonnetfile.json Add trailing newline when writing a jsonnetfile.json Dec 7, 2021
@simu simu requested a review from ccremer December 7, 2021 17:09
@simu simu merged commit 69c8107 into master Dec 8, 2021
@simu simu deleted the feat/add-trailing-newline-in-jsonnetfile-json branch December 8, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccremer ccremer ccremer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simu @ccremer