Add support for selective dependency syncing #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glrf
approved these changes
Oct 27, 2022
simu
force-pushed
the
feat/refactor-cli
branch
from
acc2a74 to
7bc3fa4
Compare
We'll add support for filtering the loaded dependencies in the function. Having this separated out from `sync_dependencies()` should make testing the filtering fairly straightforward.
simu
force-pushed
the
feat/dependency-sync/filter
branch
from
c0d26c1 to
e2d60c8
Compare
simu
force-pushed
the
feat/dependency-sync/filter
branch
from
e2d60c8 to
a4628b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new option
--filter REGEXforcomponent syncandpackage sync. This option allows callers to selectively sync only dependencies which match the provided regex. The base set of dependencies is still always loaded from the given YAML file.In the dependency syncer implementation, the PR moves loading and filtering of the dependency file into a separate function.
Resolves #615
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog