Add support for taking over library prefix of deprecated components #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
changed the title
simu
force-pushed
the
feat/steal-libalias-prefix
branch
from
08b7115 to
ff85b41
Compare
simu
force-pushed
the
feat/steal-libalias-prefix
branch
3 times, most recently
from
6d31d0a to
163edb2
Compare
…ents Commodore will verify that either the component who's prefix we're trying to take over isn't present in the cluster configuration (in this case the alias is just a regular alias) or that the component is deprecated, and has nominated us as their replacement component. Library prefixes of non-deprecated components, or deprecated components which don't specify a replacement can't be taken over.
Allow specifying full `_metadata` through test parametrization. This allows us to reuse the test to specify test cases for taking over library prefixes.
simu
force-pushed
the
feat/steal-libalias-prefix
branch
from
163edb2 to
6c1872b
Compare
simu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commodore will verify that either the component who's prefix we're trying to take over isn't present in the cluster configuration (in this case the alias is just a regular alias) or that the component is deprecated, and has nominated us as their replacement component. Library prefixes of non-deprecated components, or deprecated components which don't specify a replacement can't be taken over.
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog