Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to upstream Cruft #768

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Switch to upstream Cruft #768

merged 2 commits into from
Apr 4, 2023

Conversation

simu
Copy link
Member

@simu simu commented Apr 4, 2023

Cruft merged all PRs which Commodore's template rendering and syncing requires (cruft/cruft#159 and cruft/cruft#167). This PR updates Commodore to no longer vendor a patched version of Cruft (cf. #553) and instead adds the upstream Cruft package to the project dependencies.

Additionally, we remove cookiecutter and typer from the project dependencies, since we no longer directly depend on those packages, now that cruft is a project dependency, and not vendored as package commodore.cruft anymore.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog
  • Link this PR to related issues.

@simu simu added the dependency Pull requests that update a dependency file label Apr 4, 2023
@simu simu marked this pull request as ready for review April 4, 2023 14:48
@simu simu requested a review from a team as a code owner April 4, 2023 14:48
@simu simu force-pushed the deps/upstream-cruft branch from 51efd6b to 975cc51 Compare April 4, 2023 14:50
Copy link
Contributor

@glrf glrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@simu simu merged commit 0ace291 into master Apr 4, 2023
@simu simu deleted the deps/upstream-cruft branch April 4, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants