Convert all f-strings without interpolations to regular strings #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses pylint failures for "W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)".
srueg
approved these changes
May 7, 2020
Pin cookiecutter to 1.7.0 for the moment to avoid unresolvable dependency requirements for requests: ``` There are incompatible versions in the resolved dependencies: requests (from -r requirements.in (line 5)) requests==2.22.0 (from kapitan==0.27.2->-r requirements.in (line 4)) requests>=2.23.0 (from cookiecutter==1.7.2->-r requirements.in (line 2)) ```
Otherwise pipenv install fails and cookiecutter (commodore new-component) doesn't work in the Docker image.
bittner
reviewed
May 11, 2020
| @@ -1,5 +1,5 @@ | |||
| click | |||
| cookiecutter | |||
| cookiecutter==1.7.0 | |||
There was a problem hiding this comment.
Why is this version pinned? Is the reason for this documented somewhere?
There was a problem hiding this comment.
See commit message for "Bulk update dependencies"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses pylint failures for "W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)".
Additionally also bulk updates dependencies, and fixes the Docker image build