removed unshift and using the standard assignment operators, as there…

… are cases when the observation values could alredy have 2 values in the array
projecttacoma · Feb 9, 2024 · 44b3914 · 44b3914
1 parent 938b45a
commit 44b3914
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/dist/browser.js b/dist/browser.js
@@ -122,13 +122,15 @@ module.exports = class CalculatorHelpers {
         }
         if ('observation_values' in populationResults) {
           // DENOM observation will be the first of 2 observations
-          populationResultsHandled.observation_values.unshift(0);
+          populationResultsHandled.observation_values[1] = populationResultsHandled.observation_values[0];
+          populationResultsHandled.observation_values[0] = 0;
         }
       }
       if (populationResults.DENEX != null && !this.isValueZero('DENEX', populationResults) && populationResults.DENEX >= populationResults.DENOM) {
         if ('observation_values' in populationResults) {
           // DENOM observation will be the first of 2 observations
-          populationResultsHandled.observation_values.unshift(0);
+          populationResultsHandled.observation_values[1] = populationResultsHandled.observation_values[0];
+          populationResultsHandled.observation_values[0] = 0;
         }
       }
       if (this.isValueZero('NUMER', populationResults)) {

diff --git a/lib/helpers/calculator_helpers.js b/lib/helpers/calculator_helpers.js
@@ -116,13 +116,15 @@ module.exports = class CalculatorHelpers {
         }
         if ('observation_values' in populationResults) {
           // DENOM observation will be the first of 2 observations
-          populationResultsHandled.observation_values.unshift(0);
+          populationResultsHandled.observation_values[1] = populationResultsHandled.observation_values[0];
+          populationResultsHandled.observation_values[0] = 0;
         }
       }
       if (populationResults.DENEX != null && !this.isValueZero('DENEX', populationResults) && populationResults.DENEX >= populationResults.DENOM) {
         if ('observation_values' in populationResults) {
           // DENOM observation will be the first of 2 observations
-          populationResultsHandled.observation_values.unshift(0);
+          populationResultsHandled.observation_values[1] = populationResultsHandled.observation_values[0];
+          populationResultsHandled.observation_values[0] = 0;
         }
       }
       if (this.isValueZero('NUMER', populationResults)) {