-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/numerator obs values #260
Conversation
… are cases when the observation values could alredy have 2 values in the array
@RohitKandimalla is it possible to post the contents of the JIRA issue (https://jira.cms.gov/browse/MAT-6623 ) in this pull request? I'm having trouble understanding what this is trying to fix. |
Sure I add a screenshot, so that it will easier to understand c&p the contents. The over all issue is that Numerator Observations results are not returned by cqm-execution. Technically, cql-execution is returning us the num_obs values, but during the construction of observation_values array, we are overriding existing values instead of unshifting the array. |
b5a8f87
Pull requests into cqm-execution require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.
Case: While generating observation results for each episode, we verify if the episode is a part of Numerator or Denominator, When Episode is not a part of Denominator, then the first index of
observation_values
array for that episode should be defaulted to 0.Bug: Instead of adding 0 at the first index, we are replacing the existing value, which could be the value of Numerator Observation.
https://jira.cms.gov/browse/MAT-6623
Screenshot of the contents from This story
Submitter:
Reviewer 1:
Name:
Reviewer 2:
Name: