Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-6467 Add Location Type missing entity to AnyEntity instanceof check condition #216

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Nov 20, 2023

When we added the Location Entity model to cqm-models as part of QDM 5.6 spec, we missed a condition to check instanceof Location when we typecast the entity object. This PR adds the instanceof check on Location so that we can avoid recasting, instead just return same instance.

Pull requests into cqm-models require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR: MAT-6467 Add Location Type to AnyEntity in CQM-Models
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass
  • If applicable, the library version number in package.json and cqm-models.gemspec has been updated
  • Cqm-execution fixtures have been updated with the update_cqm_execution_fixtures.sh script inside server-scripts using this branch in the cqm-converter

Bonnie Reviewer:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Cypress Reviewer:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@adongare adongare changed the title MAT-6467 Add Location Type missing entity to AnyEntity instanceof che… MAT-6467 Add Location Type missing entity to AnyEntity instanceof check condition Nov 20, 2023
@adongare adongare marked this pull request as ready for review November 20, 2023 18:12
@adongare adongare merged commit a8492db into master Nov 20, 2023
0 of 3 checks passed
@adongare adongare deleted the MAT-6467 branch November 20, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants