Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1473 - Include clause uncoverage HTML #90

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Conversation

zacharyrobin
Copy link
Contributor

@zacharyrobin zacharyrobin commented Apr 12, 2024

Summary

This adds the ability to view uncoverage in fqm-testify

Jira: TACOSTRAT-1473

New Behavior

Screenshot 2024-04-12 at 10 34 43 AM

Code Changes

  • New css file for styling
  • Main changes are in coverage.tsx with fancy new tabs
  • PopulationCalculation.tsx is also updated to send over the groupClauseUncoverageHTML

Testing Guidance

Requires groupClauseUncoverageHTML from fqm-execution. Once the newest release for fqm-execution is out this shouldnt be an issue but to test in current version youll need to use npm link. Run npm link ../fqm-execution to link to local node module.

you can double check this worked by navigating to /fqm-testify/node_modules/fqm-executio and the module should look like the local fqm-execution directory.

  • npm run check
  • npm run dev and navigate to http://localhost:3000

Additional Notes / Future Tickets

Had a discussion with @lmd59 about changing clauseCoverageHTML to groupClauseCoverageHTML. Will eventually need to add ability for fqm-testify to handle group clauses, could do a tab system. I left a comment in the code with a TODO for future reference.

pages/[measureId]/coverage.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a first pass so we can have a tool for quickly looking at the uncoverage.

@elsaperelli elsaperelli merged commit 5f262b6 into main Apr 16, 2024
1 check passed
@elsaperelli elsaperelli deleted the show-uncoverage-button branch April 16, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants