Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional params to make() method #12

Merged
merged 6 commits into from
Jun 20, 2020
Merged

Add optional params to make() method #12

merged 6 commits into from
Jun 20, 2020

Commits on Jun 20, 2020

  1. feat: add optional params 

    Signed-off-by: Fery Wardiyanto <ferywardiyanto@gmail.com>
    @feryardiant
    feryardiant committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    64024a3 View commit details
    Browse the repository at this point in the history

  2. chore: decrease line of codes 😓 

    Signed-off-by: Fery Wardiyanto <ferywardiyanto@gmail.com>
    @feryardiant
    feryardiant committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    512222e View commit details
    Browse the repository at this point in the history

  3. chore: decrease line of codes (again) 😓 

    Signed-off-by: Fery Wardiyanto <ferywardiyanto@gmail.com>
    @feryardiant
    feryardiant committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    cfd6a41 View commit details
    Browse the repository at this point in the history

  4. chore: should able to invoke non-static method like a static 

    Signed-off-by: Fery Wardiyanto <ferywardiyanto@gmail.com>
    @feryardiant
    feryardiant committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    c997629 View commit details
    Browse the repository at this point in the history

  5. chore: make first param accept string or callable 

    Signed-off-by: Fery Wardiyanto <ferywardiyanto@gmail.com>
    @feryardiant
    feryardiant committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    d0be53c View commit details
    Browse the repository at this point in the history

  6. chore: make sure it could handle closure 

    Signed-off-by: Fery Wardiyanto <ferywardiyanto@gmail.com>
    @feryardiant
    feryardiant committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    b685fde View commit details
    Browse the repository at this point in the history