Revert "package: Expand "*" to empty if it matches CC" #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neither CI failure is related to my PR. |
This reverts commit 2e079dd. Given a package list containing `=category/package-${PV}*`, nattka will remove the `*` and not replace it with a list of architecture keywords iff the set of architectures to be CC'd matches the set of stable keywords for `=category/package-${PV}`. This behavior was added in commit 2e079dd ("package: Expand "*" to empty if it matches CC") to allow reusing a stabilization bug for an additional architecture by only adding the new architecture to the CC list. This has the unfortunate side-effect of making a nattka-processed package list unacceptable to nattka itself if the package list needs to be modified. See https://bugs.gentoo.org/920053#c18 for example. Revert to the original behavior of always expanding `*` to the architecture list. If a stabilization needs to happen on an additional architecture, the additional architecture keyword should be added to the package list so nattka can sanity-check it. Signed-off-by: Matt Turner <mattst88@gentoo.org>
mattst88
force-pushed
the
always-expand-asterisk
branch
from
39ffa7d to
030ea2c
Compare
|
I think there's arguments for both behaviours, but I prefer the change you're proposing, because the status quo is destructive wrt package list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "package: Expand "*" to empty if it matches CC"
This reverts commit 2e079dd.
Given a package list containing
=category/package-${PV}*, nattka willremove the
*and not replace it with a list of architecture keywordsiff the set of architectures to be CC'd matches the set of stable
keywords for
=category/package-${PV}.This behavior was added in commit 2e079dd ("package: Expand "*" to empty
if it matches CC") to allow reusing a stabilization bug for an
additional architecture by only adding the new architecture to the CC
list.
This has the unfortunate side-effect of making a nattka-processed
package list unacceptable to nattka itself if the package list needs to
be modified. See https://bugs.gentoo.org/920053#c18 for example.
Revert to the original behavior of always expanding
*to thearchitecture list. If a stabilization needs to happen on an additional
architecture, the additional architecture keyword should be added to the
package list so nattka can sanity-check it.
Signed-off-by: Matt Turner mattst88@gentoo.org
Related: #36