Improve container setup and add script to run the prolfquapp container #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leoschwarz
commented
Sep 26, 2024
•
leoschwarz
commented
- A bash script is added that can be used to run the container easily with podman or Docker.
- The Dockerfile uses a multi-stage build to make building faster and simpler, while simultaneously reducing image size.
leoschwarz
force-pushed
the
improve-docker-setup
branch
from
7736a7f to
abb75b8
Compare
leoschwarz
commented
Sep 26, 2024
|
|
||
| # Default values for arguments | ||
| IMAGE_VERSION="0.0.1" | ||
| IMAGE_REPO="docker.io/leoschwarz/prolfquapp" |
There was a problem hiding this comment.
Currently, this is going through my Docker Hub account but I would suggest to create an organization either for prolfqua or FGCZ.
Currently deployment is manual, we can set up a GitHub actions pipeline again later but it needs to be slightly adjusted for Docker Hub.
leoschwarz
force-pushed
the
improve-docker-setup
branch
2 times, most recently
from
c206ed6 to
4a5b3fa
Compare
leoschwarz
force-pushed
the
improve-docker-setup
branch
from
4a5b3fa to
0916c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.