Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to swift 5.1.2 #33

Merged
merged 11 commits into from
Jan 29, 2020
Merged

Update to swift 5.1.2 #33

merged 11 commits into from
Jan 29, 2020

Conversation

davidrynn
Copy link
Contributor

  • Updated via tool
  • Updated hash protocol

@davidrynn
Update to swift 5.0
6c14932 
- Updated via tool
- Updated hash protocol
hkellaway
hkellaway approved these changes Jan 29, 2020
View reviewed changes
Copy link

@hkellaway hkellaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed closely - trusting you've tested for your needs

@hkellaway hkellaway mentioned this pull request Jan 29, 2020
Closed
@davidrynn davidrynn changed the title Update to swift 5.0 Update to swift 5.1.2 Jan 29, 2020
MichaelCampbell
MichaelCampbell approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@MichaelCampbell MichaelCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please address the inline comments

Example/Marker-Example.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Example/Marker-Example.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Marker/Marker/Parser/Rule.swift Show resolved Hide resolved
@MichaelCampbell MichaelCampbell merged commit 50cd9e5 into prolificinteractive:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelCampbell MichaelCampbell MichaelCampbell approved these changes

@hkellaway hkellaway hkellaway approved these changes

@livtay livtay livtay approved these changes

@jgsamudio jgsamudio Awaiting requested review from jgsamudio

Assignees

@davidrynn davidrynn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidrynn @MichaelCampbell @hkellaway @livtay