fix: Don't log config deployments

Avoid logging on some config files may contain secrets. Fixes: #72 Signed-off-by: prombot <prometheus-team@googlegroups.com>
prometheus-community · Mar 17, 2023 · e39934b · e39934b
1 parent 045d154
commit e39934b
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 3 deletions.
diff --git a/roles/alertmanager/tasks/configure.yml b/roles/alertmanager/tasks/configure.yml
@@ -17,6 +17,7 @@
     group: alertmanager
     mode: 0644
     validate: "{{ _alertmanager_binary_install_dir }}/amtool check-config %s"
+  no_log: "{{ 'false' if lookup('env', 'CI') else 'true' }}"
   notify:
     - restart alertmanager
 

diff --git a/roles/mysqld_exporter/tasks/configure.yml b/roles/mysqld_exporter/tasks/configure.yml
@@ -23,6 +23,7 @@
     owner: root
     group: root
     mode: 0644
+  no_log: "{{ 'false' if lookup('env', 'CI') else 'true' }}"
   notify: restart mysqld_exporter
 
 - name: Configure mysqld_exporter web config

diff --git a/roles/prometheus/tasks/configure.yml b/roles/prometheus/tasks/configure.yml
@@ -33,6 +33,7 @@
     group: prometheus
     mode: 0640
     validate: "{{ _prometheus_binary_install_dir }}/promtool check config %s"
+  no_log: "{{ 'false' if lookup('env', 'CI') else 'true' }}"
   notify:
     - reload prometheus
 

diff --git a/roles/snmp_exporter/molecule/alternative/converge.yml b/roles/snmp_exporter/molecule/alternative/converge.yml
@@ -4,6 +4,5 @@
   roles:
     - prometheus.prometheus.snmp_exporter
   vars:
-    __testing_on_travis: true
     snmp_exporter_web_listen_address: "127.0.0.1:9116"
     snmp_exporter_config_file: snmp.yml
diff --git a/roles/snmp_exporter/molecule/default/converge.yml b/roles/snmp_exporter/molecule/default/converge.yml
@@ -4,5 +4,4 @@
   roles:
     - prometheus.prometheus.snmp_exporter
   vars:
-    __testing_on_travis: true
     snmp_exporter_web_listen_address: "127.0.0.1:9116"
diff --git a/roles/snmp_exporter/tasks/configure.yml b/roles/snmp_exporter/tasks/configure.yml
@@ -32,7 +32,7 @@
     owner: root
     group: root
     mode: 0644
-  no_log: "{{ 'true' if __testing_on_travis is defined else 'false' }}"
+  no_log: "{{ 'false' if lookup('env', 'CI') else 'true' }}"
   notify:
     - reload snmp exporter
   when: (snmp_exporter_config_file)