Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: bump support for ansible from v2.16.* to v2.17.* #414

Merged

Conversation

andygrunwald
Copy link
Contributor

@andygrunwald andygrunwald commented Sep 7, 2024

Context

Fix #386

Last version bump

The last version bump was in 2e0a30d
It is not clear to me, why the version was set down to 2.16.* (from 2.17)

A lot of changes has been between Ansible v2.16.10 and v2.17.3, see ansible/ansible@v2.16.10...v2.17.3

Ansible version

The following ansible version is used with v0.17.1 of the ansible role prometheus.prometheus:

ansible [core 2.17.3]
  config file = None
  configured module search path = ['/Users/andy.grunwald/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /opt/homebrew/Cellar/ansible/10.3.0/libexec/lib/python3.12/site-packages/ansible
  ansible collection location = /Users/andy.grunwald/.ansible/collections:/usr/share/ansible/collections
  executable location = /opt/homebrew/bin/ansible
  python version = 3.12.5 (main, Aug  6 2024, 19:08:49) [Clang 15.0.0 (clang-1500.3.9.4)] (/opt/homebrew/Cellar/ansible/10.3.0/libexec/bin/python)
  jinja version = 3.1.4
  libyaml = True

@github-actions github-actions bot added minor and removed minor labels Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

@andygrunwald
Copy link
Contributor Author

The GitHub Action workflow failure in Ansible CI / ansible-test-sanity / sanity-stable-2.9 (pull_request) is due to a non available docker image that can't be pulled. The failure is not PR / change related.

PRs like #411 may a solution to this.

@gardar
Copy link
Member

gardar commented Sep 28, 2024

Context

Fix #386

Last version bump

The last version bump was in 2e0a30d
It is not clear to me, why the version was set down to 2.16.* (from 2.17)

At that time 2.17 was unreleased, but those two are essentially equal, the operator "less than" 2.17 and "less than or equal to" 2.16.99

The reason for the change was due to how we are using the supported versions to do testing in the CI, but it has the same effect for the user.

Anyways, thanks for the PR, can you rebase?

Fix prometheus-community#386

Signed-off-by: Andy Grunwald <andygrunwald@gmail.com>
…or Ansible 2.17

Full error:
ERROR: tests/integration/molecule.sh:54:1: SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Signed-off-by: Andy Grunwald <andygrunwald@gmail.com>
Signed-off-by: Andy Grunwald <andygrunwald@gmail.com>
@andygrunwald
Copy link
Contributor Author

@gardar Rebased.

Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to exclude 2.17 from almalinux-8, since 2.17 is not supported on el8 based distros.

You can do so by adding it here:

host_vars:
fedora-39:
exclude_ansible_vers:
- "2.9"
- "2.10"
- "2.11"
fedora-40:
exclude_ansible_vers:
- "2.9"
- "2.10"
- "2.11"
ubuntu-24.04:
exclude_ansible_vers:
- "2.9"
- "2.10"
- "2.11"

@github-actions github-actions bot added minor and removed minor labels Sep 30, 2024
Signed-off-by: Andy Grunwald <andygrunwald@gmail.com>
@andygrunwald
Copy link
Contributor Author

@gardar Excluded in e0d0aa4

@github-actions github-actions bot added minor and removed minor labels Sep 30, 2024
@gardar gardar merged commit 79fbda7 into prometheus-community:main Sep 30, 2024
600 checks passed
thalesmg added a commit to thalesmg/tf-emqx-performance-test that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment